Module bp : fix to ticket #686 (2FA problem)
Fix for module bp : woob was not able to connect to La Banque Postale with strong authentication (2FA). This fix is not fully tested : it works when the 2FA challenge has already succeeded, but it should be tested by someone that has not fulfilled the challenge within last 90 days. Still, I believe it would be usefull to merge.
Merge request reports
Activity
mentioned in issue #686 (closed)
assigned to @llange
added capbanking modules labels
added 9 commits
-
0198507c - 1 commit from branch
woob:master - 616df660 - 2FA fonctionnel mais systématique
- cce04ec5 - test qui fonctionne après 2FA validé
- b4ae7ff8 - ok quand 2FA ne demande pas d'interaction avec le téléphone. A vérifier dans 90 jours...
- aa1758f0 - ok quand 2FA ne demande pas d'interaction avec le téléphone. A vérifier dans 90 jours...
- 7ea1180a - suppression de warnings
- bb1c3177 - suppression des logs de debug
- 050c6409 - pyflakes passed
- 98f0e99c - flake8 passed
Toggle commit list-
0198507c - 1 commit from branch
requested review from @llange
Hi @rozenknop, could you please rework a little bit the commits so that:
- The title is prefixed with the name of the module. Here I believe "
[bp] ..." will work. - There are no commits with the same title.
- The commit message is more descriptive. Title is mandatory, but also a proper description (separated with a blank line please)
- Each commit address a specific point. Here it can also be a unique commit for the whole fix ("squashing")
Let me know if you have trouble doing it, unfortunately I cannot update the MR on my side (maybe it's something that you can enable / disable ?)
- The title is prefixed with the name of the module. Here I believe "
Hi @llange, I've just learnt how to squash commits. I hope the commit message is ok now.
Edited by Antoine Rozenknop
added 1 commit
- 6b407b21 - [bp] fix to ticket #686 (closed) (2FA problem)
