Skip to content

Manifest: Allow specify globs for preprocessor dependencies

Thomas Letan requested to merge lthms@manifest-ppx-glob into master

What

Add support for glob_files in the preprocessor_deps field

Why

When I was experimenting with ppx-blob, I noticed support for glob_files in the preprocessor_deps field was not integrating in Manifest. I added it (quite easily btw, Manifest’s abstractions seem pretty on point here).

In the end, we decided to use ocaml-crunch instead of ppx-blob, but maybe this MR might still be useful? So that folks needing globs for their ppx rewriter don’t have to do it themselves.

How

Mostly reuse existing code from the Manifest.

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports