Skip to content
Snippets Groups Projects

Draft: Pcbnew: Add "Add to selection" feature for Edit Tracks and Vias dialog

This MR adds an "Add to selection" function in "Edit Tracks and Vias" dialog, allow a user to bulk select tracks and vias that belong to a same net/has same size/etc.

All matched items will be appended to current selection. This allows adding different classes of items all into one selection.

图片

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • oops, seems clang-format changed existing code quite a bit. I doubt whether should I revert these unrelated code changes...

  • RigoLigoRLC added 33 commits

    added 33 commits

    • ce27de32...7520a8b3 - 32 commits from branch kicad/code:master
    • 472020ac - Pcbnew: Add to selection feature for edit tracks and vias dialog

    Compare with previous version

    • This MR adds an "Add to selection" function in "Edit Tracks and Vias" dialog, allow a user to bulk select tracks and vias that belong to a same net/has same size/etc.

      I'm not sure building this functionality into an edit dialog is a good step. It sounds like what you are proposing is a more detailed search functionality that adds all items matching the criteria to the selection. I think that is better done as a separate tool instead of in an edit tool.

    • I've just marked it as draft since I don't really have a good idea about how proper bulk selection can be implemented here, this MR solely tries to implement some other user's feature request.

      If a separate bulk selection tool based on filtering rules is going to be created, I still need to make a few other things clear: what can be bulk selected (graphical items? zones? footprints? should this also be a thing in schematics, or even symbol/footprint editor?) ? different kinds of items will have different filtering rule sets, how is that going to be presented in UI? Maybe there's also some other stuff I've missed here. I've just opted to take the shortest step in this dialog just for now.

    • Please register or sign in to reply
  • RigoLigoRLC marked this merge request as draft

    marked this merge request as draft

  • closed

Please register or sign in to reply
Loading