Rename NewRedisHelper to RedisHelper
requested to merge rename-new-redis-helper-redis-helper into move-remaining-redis-helper-new-redis-helper
What does this MR do?
Rename NewRedisHelper to RedisHelper. The final part of the saga.
Previous MRs:
- Add Redis settings specific to Workhorse (!7269 - merged)
- Switch KAS to use the new Redis Helper logic (!7317 - merged)
- Switch GitLab Exporter to use NewRedisHelper (!7333 - merged)
- Move Redis server information to NewRedisHelper (!7465 - merged)
- Migrate Gitlab Rails to NewRedisHelper logic (!7543 - merged)
- Move remaining uses of RedisHelper to NewRedisH... (!7544)
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-package
jobs have a green pipeline running against latest commit. -
If config/software
orconfig/patches
directories are changed, make sure thebuild-package-on-all-os
job within theTrigger:ee-package
downstream pipeline succeeded. -
If you are changing anything SSL related, then the Trigger:package:fips
manual job within theTrigger:ee-package
downstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to dev.gitlab.org
to confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.