Skip to content

Draft: utils.py: Remove the (?ms) switch at the start of _glob2re

Benjamin Schubert requested to merge bschubert/remove-multiline-switch-for-re into master

The ?ms switch stands for multiline output.

This switch is used nowhere in our codebase.

It also is problematic in multiple places where its use is deprecated since python 3.7, as now they need to be at the start of an expression, which is not the case in all the calls to it that we are doing.

If someone wants the same functionality, they should add it explictely after calling _glob2re

TODO

Still need to add a test to see how BuildStream behaves with split files that have such characters in them

Edited by Benjamin Schubert

Merge request reports